docker / cli

The Docker CLI
Apache License 2.0
4.77k stars 1.89k forks source link

Centralize init of Meter/TracerProviders #5067

Closed krissetto closed 2 months ago

krissetto commented 2 months ago

- What I did

- Description for the changelog

Centralize initialization of Meter/TracerProviders

- A picture of a cute animal (not mandatory but encouraged)

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 61.35%. Comparing base (6c70360) to head (02537ea). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5067 +/- ## ========================================== + Coverage 61.09% 61.35% +0.26% ========================================== Files 298 298 Lines 20675 20685 +10 ========================================== + Hits 12631 12691 +60 + Misses 7147 7093 -54 - Partials 897 901 +4 ```
laurazard commented 2 months ago

Chatted w/ @jsternberg, there's some other approaches that would be interesting to look at (take care of shutdown automatically in the CLI lifecycle), but he's okay with merging as-is for now to unblock releases and improving things later.