docker / cli

The Docker CLI
Apache License 2.0
4.75k stars 1.88k forks source link

Dockerfile: update ALPINE_VERSION to 3.20 #5090

Closed thaJeztah closed 1 month ago

thaJeztah commented 1 month ago

Update to the current version of Alpine, which is also the default for the golang:alpine image

- Description for the changelog

Update Dockerfile to Alpine 3.20

- A picture of a cute animal (not mandatory but encouraged)

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.34%. Comparing base (421e3b5) to head (e70f685).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5090 +/- ## ======================================= Coverage 61.34% 61.34% ======================================= Files 298 298 Lines 20706 20706 ======================================= Hits 12703 12703 Misses 7103 7103 Partials 900 900 ```
thaJeztah commented 1 month ago

Could there be any differences between this alpine version and the one used by golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine that could cause any issues? Would it make sense to try and stay on the same underlying version when possible?

Good question; I thought it was statically linked, but wanted to double check; looks like it is, so I don't think this should be a problem;

docker run -it --rm golangci/golangci-lint:v1.55.2-alpine sh -c 'ldd /usr/bin/golangci-lint'
/lib/ld-musl-aarch64.so.1: /usr/bin/golangci-lint: Not a valid dynamic program

That said, I noticed some time back that we're still on an older version of GolangCI lint (current version is v1.59.0: https://github.com/golangci/golangci-lint/releases/tag/v1.59.0), so we should also put some time in updating it to a current version.

thaJeztah commented 1 month ago

Thx both! Let me bring this one in