Closed thaJeztah closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 61.34%. Comparing base (
421e3b5
) to head (e70f685
).
Could there be any differences between this alpine version and the one used by
golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine
that could cause any issues? Would it make sense to try and stay on the same underlying version when possible?
Good question; I thought it was statically linked, but wanted to double check; looks like it is, so I don't think this should be a problem;
docker run -it --rm golangci/golangci-lint:v1.55.2-alpine sh -c 'ldd /usr/bin/golangci-lint'
/lib/ld-musl-aarch64.so.1: /usr/bin/golangci-lint: Not a valid dynamic program
That said, I noticed some time back that we're still on an older version of GolangCI lint (current version is v1.59.0: https://github.com/golangci/golangci-lint/releases/tag/v1.59.0), so we should also put some time in updating it to a current version.
Thx both! Let me bring this one in
Update to the current version of Alpine, which is also the default for the golang:alpine image
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)