search

docker / cli

The Docker CLI
Apache License 2.0
4.88k stars 1.92k forks source link

migrate to new github.com/containerd/platforms package #5092

Closed thaJeztah closed 4 months ago

thaJeztah commented 4 months ago

The github.com/containerd/containerd/platforms package was moved to a separate module in preparation of the containerd v2.0 release.

Switch to the new module, which means we also remove containerd as a direct dependency.

- A picture of a cute animal (not mandatory but encouraged)

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.32%. Comparing base (421e3b5) to head (7dc271a). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5092 +/- ## ========================================== - Coverage 61.34% 61.32% -0.03% ========================================== Files 298 295 -3 Lines 20706 20701 -5 ========================================== - Hits 12703 12695 -8 - Misses 7103 7104 +1 - Partials 900 902 +2 ```
thaJeztah commented 4 months ago

Thx! Let me bring this in; it's good to remove the direct dependency on containerd (I should probably add a dependency-check in golangci-lint to prevent it from accidentally being reintroduced 🤔); will do that in a follow-up.