search

docker / cli

The Docker CLI
Apache License 2.0
4.75k stars 1.88k forks source link

gha: update to actions/upload-artifact@v4 #5096

Closed thaJeztah closed 1 month ago

thaJeztah commented 1 month ago

v3 is using Node.js 16 which are being deprecated:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah commented 1 month ago

DOH! Doesn't work with our build actions; @crazy-max ISTR that was a known issue, but was there an update that makes it work?

crazy-max commented 1 month ago

DOH! Doesn't work with our build actions; @crazy-max ISTR that was a known issue, but was there an update that makes it work?

Ah right it needs some changes with bump to v4. See https://github.com/docker/buildx/commit/c9aeca19ce07fa7a5f2aba75ac77002abfe65f3b. In particular:

Let me know if you need help.

thaJeztah commented 1 month ago

Thanks! I'll have a look if I find time, or if someone wants to look at those changes.

I saw the warning and thought "easy fix", but forgot about the issue with v4 🙈

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.35%. Comparing base (3ba4d27) to head (b9cd722).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5096 +/- ## ========================================== - Coverage 61.37% 61.35% -0.03% ========================================== Files 298 295 -3 Lines 20718 20713 -5 ========================================== - Hits 12716 12708 -8 - Misses 7102 7103 +1 - Partials 900 902 +2 ```
laurazard commented 1 month ago

@thaJeztah @crazy-max this seems to work, LGTY?

thaJeztah commented 1 month ago

Let me bring this one in; I'll fix-up the backports to have the new commit ❤️