search

docker / cli

The Docker CLI
Apache License 2.0
4.75k stars 1.88k forks source link

vendor: github.com/docker/docker e622cea55698 (master / v27.0.0-dev) #5100

Closed thaJeztah closed 1 month ago

thaJeztah commented 1 month ago

vendor: github.com/opencontainers/image-spec v1.1.0

full diff: https://github.com/opencontainers/image-spec/compare/v1.1.0-rc5...v1.1.0

vendor: github.com/Microsoft/hcsshim v0.11.5

full diff: https://github.com/Microsoft/hcsshim/compare/v0.11.4...v0.11.5

vendor: github.com/docker/docker e622cea55698 (master / v27.0.0-dev)

full diff: https://github.com/moby/moby/compare/06e3a49d66fa454e0124bd93570aac490bbf5544...e622cea55698e824ed6e362effe1701fd1e1552f

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah commented 1 month ago

Thanks! Missed one lint failure indeed; should be fixed now

68.87 cli/command/service/update.go:1326:10: import-shadowing: The name 'network' shadows an import name (revive)
68.87       for _, network := range networks {
68.87              ^
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 61.35%. Comparing base (cd4d62e) to head (e2fc6bd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5100 +/- ## ========================================== - Coverage 61.37% 61.35% -0.03% ========================================== Files 298 295 -3 Lines 20718 20713 -5 ========================================== - Hits 12716 12708 -8 - Misses 7102 7103 +1 - Partials 900 902 +2 ```
thaJeztah commented 1 month ago

Thanks Silvin!