Closed akerouanton closed 3 months ago
Attention: Patch coverage is 50.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 61.34%. Comparing base (
9b61bbb
) to head (db2672e
).
The only thing I'm wondering is if we need to add more details about what the default is, but we can do in a follow-up.
@thaJeztah Sorry for the 1st version of this patch, it was crap. I should stop multi-tasking sometimes 😓
The only thing I'm wondering is if we need to add more details about what the default is, but we can do in a follow-up.
I think we need to update the documentation to explain how to set the default daemon-wide, how to disable ipv6 for a specific network, etc... but that's pretty much it. Do you have anything else in mind?
FWIW, we discussed docs updates a bit with @robmry and we decided to wait for at least the rc1 to start working on that -- we'd like to get every PR ready first.
- What I did
The API field
EnableIPv6
was marked as optional in our Swagger docs, and its default value in the Go client came from that field being a bool, thus defaulting to its zero value. That's not the case anymore.This field is now a
*bool
as to let daemon's config define the default value. IPv6 can still be enabled / disabled by explicitly specifying the--ipv6
flag when doingdocker network create
.- How to verify it
Start a daemon from moby/moby master branch:
Then restart the daemon with
--default-network-opt=bridge=com.docker.network.enable_ipv6=true
:- A picture of a cute animal (not mandatory but encouraged)