search

docker / cli

The Docker CLI
Apache License 2.0
4.74k stars 1.88k forks source link

gha: switch to Ubuntu 24.04 #5139

Closed thaJeztah closed 3 weeks ago

thaJeztah commented 3 weeks ago

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah commented 3 weeks ago

LOL that .. didn't go well; is docker not installed by default on 24.04 runners?

Run sudo jq '.experimental = true' < /etc/docker/daemon.json > /tmp/docker.json
  sudo jq '.experimental = true' < /etc/docker/daemon.json > /tmp/docker.json
  sudo mv /tmp/docker.json /etc/docker/daemon.json
  sudo cat /etc/docker/daemon.json
  sudo service docker restart
  docker version
  docker info
  shell: /usr/bin/bash -e {0}
/home/runner/work/_temp/5a389600-a748-4fcd-a8a9-ac63e71c765e.sh: line 1: /etc/docker/daemon.json: No such file or directory
Error: Process completed with exit code 1.
thaJeztah commented 3 weeks ago

Hm... other checks use docker as well, so perhaps it's just the daemon.json that's missing

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.79%. Comparing base (591bd17) to head (3ce3177).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5139 +/- ## ========================================== - Coverage 61.82% 61.79% -0.04% ========================================== Files 298 295 -3 Lines 20730 20725 -5 ========================================== - Hits 12817 12806 -11 - Misses 7000 7003 +3 - Partials 913 916 +3 ```
thaJeztah commented 3 weeks ago

Looks like it may be just the daemon.json that's missing; commenting-out that part looks like it works

thaJeztah commented 3 weeks ago

This should be ready for review @krissetto @crazy-max

I opened a separate ticket to look if we indeed still need the experimental checks, or if they're really redundant;