Closed Benehiko closed 3 months ago
Attention: Patch coverage is 0%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 61.72%. Comparing base (
70b53a0
) to head (faf7647
). Report is 31 commits behind head on master.
- What I did
Added a global signal handler for cases where context cancellation is not respected. This will force the CLI to exit after 3 attempts of sigint/sigterm.
- How I did it
I register a go routine to catch further signals upon running a docker command. Docker plugin handling has its own signal handling and is excluded from this signal handler.
- How to verify it
Try with
docker login
since it's currently not respecting context cancellation.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)