search

docker / cli

The Docker CLI
Apache License 2.0
4.87k stars 1.91k forks source link

vendor: github.com/docker/docker v27.0-dev (018d93decfb5) #5180

Closed vvoland closed 3 months ago

vvoland commented 3 months ago

full diff: https://github.com/docker/docker/compare/1a1f3cff45ec...018d93decfb5

Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.73%. Comparing base (334421b) to head (d1cb7d4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5180 +/- ## ========================================== - Coverage 61.76% 61.73% -0.04% ========================================== Files 297 294 -3 Lines 20768 20763 -5 ========================================== - Hits 12828 12817 -11 - Misses 7024 7027 +3 - Partials 916 919 +3 ```
thaJeztah commented 3 months ago

Hm... looks like the linter isn't happy because we're copying locks somewhere 😬

vvoland commented 3 months ago

Hmm right, Client became non-copyable due to the atomic.Bool (and implictily sync.Mutex) being added to the struct, and our fakeClient actually embeds the Client by value.