search

docker / cli

The Docker CLI
Apache License 2.0
4.87k stars 1.91k forks source link

cli/config: replace pkg/homedir dependency with local copy #5187

Closed thaJeztah closed 3 months ago

thaJeztah commented 3 months ago

There's some consumers of the config package that don't need any of the other parts of the code, but because of the pkg/homedir were now forced to also depend on docker/docker.

This patch introduces a local copy of the function to prevent this.

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.74%. Comparing base (12ea47d) to head (9f8bda1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5187 +/- ## ========================================== - Coverage 61.74% 61.74% -0.01% ========================================== Files 297 297 Lines 20781 20787 +6 ========================================== + Hits 12832 12835 +3 - Misses 7035 7037 +2 - Partials 914 915 +1 ```