- What I did
This pull request enables shell completion for these commands:
docker image rm (and its aliases docker image remove and docker rmi)
docker image history
docker image inspect
- How I did it
I have added a ValidArgsFunction to each of the relevant commands.
- How to verify it
I ran make dev to enter a development shell, and then make && ./build/docker __completeNoDesc image rm "" (and similar for the other commands being modified) to verify expected output (both before & after making code changes).
I also ran make test which reported success.
- Description for the changelog
Enable shell completion for `docker image rm`, `docker image history`, and `docker image inspect`.
- What I did This pull request enables shell completion for these commands:
docker image rm
(and its aliasesdocker image remove
anddocker rmi
)docker image history
docker image inspect
- How I did it I have added a
ValidArgsFunction
to each of the relevant commands.- How to verify it I ran
make dev
to enter a development shell, and thenmake && ./build/docker __completeNoDesc image rm ""
(and similar for the other commands being modified) to verify expected output (both before & after making code changes).I also ran
make test
which reported success.- Description for the changelog
This change fixes https://github.com/docker/cli/issues/4588.
- A picture of a cute animal (not mandatory but encouraged)![](https://images.unsplash.com/photo-1597382389726-fbe8c7a6905e?w=450)