search

docker / cli

The Docker CLI
Apache License 2.0
4.75k stars 1.88k forks source link

cli/command/container: TestSplitCpArg: cleaner skip #5230

Closed thaJeztah closed 5 days ago

thaJeztah commented 6 days ago

Trying to make the logic slightly clearer, and adding a custom message for the skip,

Before this:

=== RUN   TestSplitCpArg/absolute_path_with_drive
    cp_test.go:184: tc.os == "windows" && runtime.GOOS != "windows" || tc.os == "linux" && runtime.GOOS == "windows"

After this:

=== RUN   TestSplitCpArg/absolute_path_with_drive
    cp_test.go:184: skipping windows test on non-windows platform
codecov-commenter commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.48%. Comparing base (5aae44b) to head (88896ee).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5230 +/- ## ======================================= Coverage 61.48% 61.48% ======================================= Files 298 298 Lines 20813 20813 ======================================= Hits 12797 12797 Misses 7104 7104 Partials 912 912 ```
thaJeztah commented 6 days ago

Let me know if you like this better, @vvoland (happy to update)