Closed thaJeztah closed 5 days ago
Attention: Patch coverage is 0%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 61.47%. Comparing base (
5aae44b
) to head (bca2090
).
I have some changes staged to look at actually providing an error-message for some of these, but I need to clean it up a bit 😅 - also have https://github.com/docker/cli/pull/5229#issuecomment-2209343234 as a follow-up.
This error didn't do a great job at formatting. If a StatusError was produced without a Status message, it would print a very non-informative error, with information missing.
Let's update the output:
echo $?
in Bash).exec.ExecError
, which usesos.rocessState.String()
(see 1).Before this patch, an error without custom status would print:
After this patch:
In situations where a custom error-message is provided, the error-message is print as-is, whereas before this patch, the message got combined with the
Status:
andCode:
, which resulted in some odd output.Before this patch:
With this patch, the error is shown as-is;
While the exit-code is no longer printed, it's still properly handled;
- A picture of a cute animal (not mandatory but encouraged)