search

docker / cli

The Docker CLI
Apache License 2.0
4.96k stars 1.94k forks source link

update to go1.23.3 #5601

Closed vvoland closed 2 weeks ago

vvoland commented 2 weeks ago

go1.23.3 (released 2024-11-06) includes fixes to the linker, the runtime, and the net/http, os, and syscall packages. See the Go 1.23.3 milestone for details.

- Description for the changelog

Update Go runtime to 1.23.3
codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.63%. Comparing base (9c01d92) to head (382d4c3). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5601 +/- ## ======================================= Coverage 59.63% 59.63% ======================================= Files 346 346 Lines 29208 29208 ======================================= Hits 17417 17417 Misses 10822 10822 Partials 969 969 ```
vvoland commented 2 weeks ago

Flaky test:

 === FAIL: e2e/cli-plugins TestPluginSocketBackwardsCompatible/detached/the_main_CLI_exits_after_3_signals (1.11s)
    socket_test.go:111: docker --config /tmp/plugin-test-1548696475 presocket test-no-socket
    socket_test.go:139: assertion failed: 255 (int) != 1 (int)
    socket_test.go:140: assertion failed: expected error to contain "exit status 1", got "exit status 255"
    socket_test.go:145: assertion failed: 
        --- ←
        +++ →
        @@ -1,2 +1,2 @@
        -exit status -1
        +got 3 SIGTERM/SIGINTs, forcefully exiting

cc @laurazard @Benehiko

thaJeztah commented 2 weeks ago 
-exit status -1

That's -1 (could be some default we're setting)? or is that just poor rendering of the output? 🤔