[27.x backport] bump golangci-lint to v1.61.0 and cleanup config

docker / cli

The Docker CLI

Apache License 2.0

4.97k stars 1.94k forks source link

[27.x backport] bump golangci-lint to v1.61.0 and cleanup config #5613

Closed thaJeztah closed 1 week ago

thaJeztah commented 1 week ago

backport https://github.com/docker/cli/pull/5585

golangci-lint: enable G204, add #nosec comments instead
golangci-lint: move gosec excludes to linters-settings
golangci-lint: update comment, and disable "exclude-dirs-use-default"
bump golangci-lint to v1.61.0

- A picture of a cute animal (not mandatory but encouraged)

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.38%. Comparing base (e15a979) to head (8fe9372). Report is 32 commits behind head on 27.x.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 27.x #5613 +/- ## ========================================== - Coverage 58.65% 58.38% -0.27% ========================================== Files 345 336 -9 Lines 29053 28782 -271 ========================================== - Hits 17040 16805 -235 + Misses 11042 11010 -32 + Partials 971 967 -4 ```

thaJeztah commented 1 week ago

65.28 cli/required.go:17:24: printf: non-constant format string in call to github.com/docker/cli/vendor/github.com/pkg/errors.Errorf (govet)
65.28       return errors.Errorf("\n" + strings.TrimRight(cmd.UsageString(), "\n"))
65.28                            ^

Looks like that's fixed in https://github.com/docker/cli/commit/a6e96c758e3d3b41a2a81146342344eb82d1d4ec, part of https://github.com/docker/cli/pull/5234, but not sure if we want to backport all of that

laurazard commented 1 week ago

I think it's fine as-is.