search

docker / compose-on-kubernetes

Deploy applications described in Compose onto Kubernetes clusters
Apache License 2.0
1.42k stars 159 forks source link

Skip flaky bind mount test #110

Closed chris-crone closed 5 years ago

chris-crone commented 5 years ago

The bind mount test has been reported flaky. This PR skips it with a FIXME message.

codecov-io commented 5 years ago

Codecov Report

Merging #110 into master will decrease coverage by 0.16%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   64.73%   64.56%   -0.17%     
==========================================
  Files          90       90              
  Lines       10933    10933              
==========================================
- Hits         7077     7059      -18     
- Misses       3552     3569      +17     
- Partials      304      305       +1
Impacted Files Coverage Δ
internal/controller/resourceupdater.go 35.18% <0%> (-14.82%) :arrow_down:
internal/registry/logstreamer.go 73.72% <0%> (-1.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 093fa44...6708465. Read the comment docs.

chris-crone commented 5 years ago

I wasn't able to reproduce this locally so was working off of these logs:

• Failure in Spec Teardown (AfterEach) [37.347 seconds]
Compose fry
/go/src/github.com/docker/compose-on-kubernetes/e2e/compose_test.go:97
  Should support bind volumes [AfterEach]
  /go/src/github.com/docker/compose-on-kubernetes/e2e/compose_test.go:877

  Expected
      <bool>: false
  to be true

  /go/src/github.com/docker/compose-on-kubernetes/e2e/compose_test.go:898

It requires more investigation.

chris-crone commented 5 years ago

See: #111.