Add tests to the installer code

docker / compose-on-kubernetes

Deploy applications described in Compose onto Kubernetes clusters

Apache License 2.0

1.42k stars 159 forks source link

Add tests to the installer code #45

Closed simonferquel closed 3 years ago

simonferquel commented 5 years ago

Currently, the installer is not tested at all (except the parts used for e2e test environment deployment).

We need to improve our confidence in the installer, and thus require a bunch of unit tests and e2e tests (tests with custom TLS bundle, various ETCD configurations, ...)

waveywaves commented 5 years ago

@simonferquel I want ot take this up. Is there anything in particular I should keep in mind before starting work on this issue.

simonferquel commented 5 years ago

@waveywaves Thanks a lot for proposing this. There are 2 categories of tests we'd like to have:

Unit tests using kubernetes Fakes:
- validate that the installer creates the required entities for any given set of options (a huge matrix here, this might need some priorization)
- validate the installation state detection and the logic behind deciding to re-deploy or not given a previous state, and a new set of installation parameters (I am almost certain there are bugs lurking there)
e2e tests using Kind
- Validation against a broad set of deployment parameters (etcd with TLS, external mutual TLS bundles, different defaultServiceTypes etc.)

waveywaves commented 5 years ago

Okay, I will work on these given points. Thank you @simonferquel

waveywaves commented 5 years ago

@simonferquel I have started work on this. Please do assign this issue to me.

simonferquel commented 5 years ago

For some reason github refuses to assign it to you. I'll assign it to myself in the mean time then, to makes sure no one else works on it. Also, please open a WIP Pull Request so that we can see progress / provide early feedback.