search

docker / compose-on-kubernetes

Deploy applications described in Compose onto Kubernetes clusters
Apache License 2.0
1.42k stars 159 forks source link

Correct the metadata name under compose-etcd.yaml #54

Closed ajeetraina closed 5 years ago

ajeetraina commented 5 years ago

While you use installer script, the deploy-etcd.md specifies compose-etcd as metadata name which should match with parameter --etcd-servers specified while running installer script.

./installer-darwin -namespace=compose -etcd-servers=http://compose-etcd-client:2379 -tag=v0.4.18
INFO[0000] Checking installation state
INFO[0000] Install image with tag "v0.4.18" in namespace "compose"
INFO[0000] Api server: image: "docker/kube-compose-api-server:v0.4.18", pullPolicy: "Always"
INFO[0000] Controller: image: "docker/kube-compose-controller:v0.4.18", pullPolicy: "Always"

Correct way of using it is specified under https://collabnix.com/a-first-look-at-compose-on-kubernetes-for-minikube/

codecov-io commented 5 years ago

Codecov Report

Merging #54 into master will decrease coverage by 0.3%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   67.01%   66.71%   -0.31%     
==========================================
  Files          82       82              
  Lines        8444     8444              
==========================================
- Hits         5659     5633      -26     
- Misses       2554     2580      +26     
  Partials      231      231
Impacted Files Coverage Δ
internal/controller/resourceupdater.go 42.59% <0%> (-11.12%) :arrow_down:
internal/convert/pvc.go 82.6% <0%> (-8.7%) :arrow_down:
internal/check/check.go 58.33% <0%> (-8.34%) :arrow_down:
internal/stackresources/stackstate.go 68.42% <0%> (-7.9%) :arrow_down:
cmd/compose-controller/main.go 60.86% <0%> (-4.35%) :arrow_down:
internal/convert/stack.go 81.3% <0%> (-3.74%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55bc84a...2158c76. Read the comment docs.

simonferquel commented 5 years ago

IIRC, I think that for each etcd cluster created with etcd-operator, there is a <name>-client service created for it. I wonder if the problem was elsewhere (like the etcd-operator somehow missing the cluster CRD resource creation on first time, and the second cluster creation would wake things up or something). I know I had a similar issue where etcd-operator would not reconcile my cluster resource and I had to remove/recreate it to make it work.

@ulyssessouza can you check that on a clean minikube ?

simonferquel commented 5 years ago

I am closing the issue then, we will add a note on etcd installation doc about what could go wrong, and how to verify the etcd cluster actually got created