search

docker / compose-on-kubernetes

Deploy applications described in Compose onto Kubernetes clusters
Apache License 2.0
1.42k stars 159 forks source link

Remove Client/Server API version negotiation #56

Closed simonferquel closed 5 years ago

simonferquel commented 5 years ago

Remove Client/Server API version negotiation from this side (should be done on the docker CLI side)

codecov-io commented 5 years ago

Codecov Report

Merging #56 into master will decrease coverage by 0.1%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   65.78%   65.67%   -0.11%     
==========================================
  Files          96       94       -2     
  Lines       11032    11002      -30     
==========================================
- Hits         7257     7226      -31     
+ Misses       3493     3488       -5     
- Partials      282      288       +6
Impacted Files Coverage Δ
internal/registry/owner.go 85.71% <0%> (-14.29%) :arrow_down:
internal/convert/pvc.go 82.6% <0%> (-8.7%) :arrow_down:
internal/controller/stackreconciler.go 69.23% <0%> (-6.6%) :arrow_down:
internal/registry/stackregistry.go 68.25% <0%> (-3.18%) :arrow_down:
internal/controller/childrenstore.go 80.51% <0%> (-2.6%) :arrow_down:
internal/controller/resourceupdater.go 53.7% <0%> (-1.86%) :arrow_down:
api/config.go

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c8033cf...b4f407a. Read the comment docs.

simonferquel commented 5 years ago

@silvin-lubecki @chris-crone PTAL (changed to removing the negociation part to put it in the CLI codebase)