Closed neerolyte closed 5 years ago
Merging #61 into master will decrease coverage by
0.36%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 65.82% 65.46% -0.37%
==========================================
Files 94 94
Lines 11008 11008
==========================================
- Hits 7246 7206 -40
- Misses 3479 3514 +35
- Partials 283 288 +5
Impacted Files | Coverage Δ | |
---|---|---|
internal/controller/resourceupdater.go | 35.18% <0%> (-24.08%) |
:arrow_down: |
internal/convert/pvc.go | 82.6% <0%> (-8.7%) |
:arrow_down: |
internal/check/check.go | 58.33% <0%> (-8.34%) |
:arrow_down: |
internal/stackresources/stackstate.go | 68.42% <0%> (-7.9%) |
:arrow_down: |
internal/controller/stackreconciler.go | 69.23% <0%> (-6.6%) |
:arrow_down: |
cmd/compose-controller/main.go | 60.86% <0%> (-4.35%) |
:arrow_down: |
internal/convert/stack.go | 81.3% <0%> (-3.74%) |
:arrow_down: |
internal/controller/childrenstore.go | 83.11% <0%> (+2.59%) |
:arrow_up: |
internal/registry/stackregistry.go | 71.42% <0%> (+3.17%) |
:arrow_up: |
internal/registry/owner.go | 100% <0%> (+14.28%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 565edc4...9157c6a. Read the comment docs.
@neerolyte I made some sort-of-related changes in #62, but they shouldn't conflict at all. Perhaps you might want to steal the Compose on Kubernetes requires an etcd instance (in addition to the kube-system etcd instance). Please follow [How to deploy etcd](./deploy-etcd.md).
wording I used there for consistency (but what you have here is also fine I think, just the title needs fixing).
I've managed to get Compose on Kubernetes running via this procedure, it was a bit finicky and could probably do with some actual troubleshooting notes, but it's a start.
This would have been enough to get me past https://github.com/docker/compose-on-kubernetes/issues/59 .