docker / compose-on-kubernetes

Deploy applications described in Compose onto Kubernetes clusters
Apache License 2.0
1.42k stars 159 forks source link

Etcd docs clarifications #62

Closed ijc closed 5 years ago

ijc commented 5 years ago

(more on each of those in the respective commit messages)

Fixes #60.

silvin-lubecki commented 5 years ago

@ijc you may need to rebase on top of #61 once it is merged and apply your modifications on it too.

codecov-io commented 5 years ago

Codecov Report

Merging #62 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   65.82%   65.79%   -0.03%     
==========================================
  Files          94       94              
  Lines       11008    11008              
==========================================
- Hits         7246     7243       -3     
- Misses       3479     3481       +2     
- Partials      283      284       +1
Impacted Files Coverage Δ
internal/convert/pod.go 87% <0%> (-1%) :arrow_down:
internal/controller/resourceupdater.go 58.33% <0%> (-0.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 565edc4...8583094. Read the comment docs.

ijc commented 5 years ago

@silvin-lubecki given the timezones (I believe the author of #61 may be in Australia) and that there's a correction required there (title says minikube) perhaps we should merge this first and ask for #61 to be rebased overnight (for us)?

chris-crone commented 5 years ago

Technically Compose on Kubernetes just needs access to an etcd. It doesn't have to be a new one and it could (in theory) be shared with Kubernetes itself. From what I remember some (all?) hosted Kubernetes don't allow you to share their etcd. Not sure if that's the case with things like Minikube or other Kubernetes distributions though.

This is more a clarification than anything and primarily a concern for production. In terms of documentation, we actually want three sets of instructions:

  1. How to quickly get things going so that you can play with Compose on Kubernetes (we have these – edited above)
  2. How to develop Compose on Kubernetes (we have this for Docker Desktop)
  3. How to set Compose on Kubernetes up for production (we have nothing here)
ijc commented 5 years ago

@chris-crone indicated to me elsewhere that he considers this a net improvement which shouldn't be blocked by the above comment. So, merging.