search

docker / compose-on-kubernetes

Deploy applications described in Compose onto Kubernetes clusters
Apache License 2.0
1.42k stars 159 forks source link

Make waitUntil report more details on calling site #65

Closed simonferquel closed 5 years ago

simonferquel commented 5 years ago

When a waitUntil fails, we do not get details about where it was called within the test. That is due to it relying on expectNoError that rewind only 1 step in the calling stack (thus reporting error call site as coming from waitUntil). This PR fix the issue.

codecov-io commented 5 years ago

Codecov Report

Merging #65 into master will increase coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   65.71%   65.77%   +0.05%     
==========================================
  Files          94       94              
  Lines       11008    11008              
==========================================
+ Hits         7234     7240       +6     
+ Misses       3487     3482       -5     
+ Partials      287      286       -1
Impacted Files Coverage Δ
internal/convert/pvc.go 82.6% <0%> (-8.7%) :arrow_down:
internal/controller/resourceupdater.go 55.55% <0%> (+1.85%) :arrow_up:
internal/controller/stackreconciler.go 75.82% <0%> (+6.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1086f20...83e6e3a. Read the comment docs.