simonferquel commented 5 years ago

fix #64 This changes the service creation logic to use ClusterIP instead of Headless services for internal communication. This is done if the InternalPorts collection on a Service is not empty.

codecov-io commented 5 years ago

Codecov Report

Merging #80 into master will decrease coverage by 0.82%. The diff coverage is 67.69%.

@@            Coverage Diff            @@
##           master     #80      +/-   ##
=========================================
- Coverage   66.03%   65.2%   -0.83%     
=========================================
  Files          88      77      -11     
  Lines       10945   10488     -457     
=========================================
- Hits         7227    6839     -388     
+ Misses       3432    3412      -20     
+ Partials      286     237      -49

Impacted Files	Coverage Δ
api/compose/v1alpha3/stack.go	`0% <ø> (-40%)`	:arrow_down:
api/compose/latest/aliases.go	`0% <ø> (ø)`	:arrow_up:
internal/controller/resourceupdater.go	`0% <0%> (-53.22%)`	:arrow_down:
internal/stackresources/diff/stackstatediff.go	`86.95% <100%> (+1.24%)`	:arrow_up:
internal/convert/service.go	`97.65% <100%> (-1.43%)`	:arrow_down:
api/compose/v1alpha3/deepcopy_generated.go	`28.66% <30.76%> (+0.06%)`	:arrow_up:
internal/version.go	`0% <0%> (-100%)`	:arrow_down:
internal/controller/childrenstore.go	`14.28% <0%> (-68.84%)`	:arrow_down:
internal/check/check.go	`0% <0%> (-58.34%)`	:arrow_down:
cmd/compose-controller/main.go	`0% <0%> (-57.3%)`	:arrow_down:
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 743df77...9848156. Read the comment docs.

simonferquel commented 5 years ago

@chris-crone PTAL (and someone else as well) :)

docker / compose-on-kubernetes

Networking update - ClusterIP instead of Headless services #80

Codecov Report