search

docker / desktop-linux

Bug reports for Docker Desktop for Linux
https://docs.docker.com/desktop/linux/
81 stars 5 forks source link

Exiting Docker Desktop UI also closes any open terminal windows #109

Open random-pixels opened 1 year ago

random-pixels commented 1 year ago

Issue is that when exiting the Docker Desktop UI by right-clicking on the icon in the system notification area, terminal windows are also closed (even if you are actively typing in them or they are producing output at the time).

I can't find any option within Docker Desktop to disable this behaviour, so I assume it's an unintended (and frustrating) bug.

This happens on a fresh install of Docker Desktop with no images, volumes, containers, etc as well as an updated Docker Desktop as well as Docker Desktop containing 2-3 images, containers and one volume.

Expected behavior

Steps to reproduce the behavior

I don't think you need any Docker images, any special settings, modifications, extensions as this issue happens straight out of the box. Docker is not logged in with an account or connected to anything remote. Also, it does not matter if the terminal window(s) were opened before or after Docker Desktop.

  1. Open a terminal command window(s)
  2. Open Docker Desktop
  3. Close Docker Desktop (which minimizes it to the system notification area)
  4. Exit Docker Desktop by right-clicking on its icon in the notification area
  5. Observe that the terminal command window closes at the same instant as Docker Desktop exits
tsoud commented 1 year ago

Exact same issue here, with same steps. Linux Mint (21.1 - Vera). Docker Desktop v4.16.2

rmwiseman commented 1 year ago

Exact same issue here, with same steps. Linux Mint (21.1 - Vera). Docker Desktop v4.16.2

Exact same issue, steps, Mint version and Docker Desktop version here too.

jacksontong commented 1 year ago

Exact same issue here, with same steps. Linux Mint (21.1 - Vera). Docker Desktop v4.16.2

Same issue.

brianschubert commented 1 year ago

Same issue here. Right-clicking on the Docker Desktop icon in the system tray and clicking "Quit Docker Desktop" results in all open gnome-terminal windows being closed at the same time as the Docker Desktop UI.

It seems that Docker Desktop is killing the gnome-terminal-server process on exit.

Reproduced in

As a mitigation, I discovered that Docker Desktop only kills the default gnome-terminal-server process that is spawned in the background by gnome-terminal. If you start gnome-terminal-server manually, it survives Docker Desktop shutdown.

Mitigation Steps

  1. Kill any existing instance of gnome-terminal-server. This can be done by closing Docker Desktop per this issue, or by killing the process manually, e.g. by finding its PID with ps aux | grep gnome-terminal-server and then kill <pid> . This will kill any open gnome terminals windows.
  2. Start gnome-terminal-server without opening a terminal. In Cinnamon, this can be done by typing ALT+F2 and entering /usr/libexec/gnome-terminal-server (the full path to the gnome-terminal-server executable).
    1. Note: if you just start gnome-terminal from the ALT+F2 menu, the background gnome-terminal-server process that it creates will still not survive Docker Desktop shutdown.
  3. Open terminals like normal. All new gnome-terminal windows should now connect to the gnome-terminal-server process you started, and should now survive Docker Desktop shutdown.
rmunn commented 1 year ago

Still occurring with Docker Desktop version 4.21.1. All reports of this so far (including me) have been using Linux Mint 21; perhaps this behavior is specific to Mint and/or the Cinnamon desktop environment. The workaround from https://github.com/docker/desktop-linux/issues/109#issuecomment-1544438060 has been working for me, but it shouldn't really be necessary: Docker Desktop shouldn't be killing processes it didn't start.

fmichel commented 1 year ago

Still occurring with 4.24.2, on Archlinux with lxde. So it is not specific to Mint and pretty annoying...

pimisen commented 9 months ago

Still an issue in 4.27! Also on Debian 12 with cinnamon. VERY anoying!

rmunn commented 5 months ago

Still occurring with version 4.30.0-149282. The workaround from https://github.com/docker/desktop-linux/issues/109#issuecomment-1544438060 (start gnome-terminal-server manually first, and only then start docker-desktop) continues to work.

vitali-yanushchyk-valor commented 1 month ago

Still occurring. v.4.34.2 (167172)

rmunn commented 14 hours ago

Still occurring with version 4.35.1-173168 of the docker-desktop-amd64.deb package.

As an aside, this is why I prefer to use open-source tools. It's been nearly two years since this issue was reported, and the Docker Desktop devs (who are quite busy with other tasks) haven't gotten around to looking into this issue yet, or even saying anything on the issue thread. With an open-source tool, I could dive into the code, figure out where it's killing gnome-terminal-server, and figure out how to make Docker Desktop check first whether that process is the one that it started itself, rather than blindly (and rudely) killing a process that it didn't start.

But since this tool isn't open source, all I can do is keep commenting when new versions come out without this bug being addressed. It's a little frustrating that no communication at all has happened. Docker Desktop dev team, I know quite well how busy you can be, but this bug is both high on the "user annoyance" factor and high on the "easy to fix" factor, which makes it low-hanging fruit. Please at least say something in the comments so we know you're aware of the problem and looking into it.

And yes, I'm fully aware that it might turn out to actually not be easy to fix. But since I can't know for certain, as this tool is not open-source, all I can do is guess. And my guess, based on previous experience with other bugs in other tools, is that this would be fairly straightforward to fix for anyone with intermediate-to-expert skills with Linux. Surely you must have some of those people on your team. We'd love to hear from them.

Danita commented 2 hours ago

@akerouanton Yes please, a word from the developers would be greatly appreciated.

gdbonino commented 1 hour ago

This issue is almost two years old. It is really annoying that every time I close Docker Desktop all terminals close.