fix: set docker-bench-security to sh

docker / docker-bench-security

The Docker Bench for Security is a script that checks for dozens of common best-practices around deploying Docker containers in production.

Apache License 2.0

9.17k stars 1.02k forks source link

fix: set docker-bench-security to sh #474

Closed denhamparry closed 3 years ago

denhamparry commented 3 years ago

Closes #473
Set script to execute with sh rather than bash
Dockerfile is based on Alpine 13.3 that has sh and not bash

konstruktoid commented 3 years ago

Thanks for this PR @denhamparry, I forgot to fix the Alpine Dockerfile when changing to bash. My suggested change is instead: ENTRYPOINT [ "/usr/bin/dumb-init", "/bin/sh", "docker-bench-security.sh" ]

denhamparry commented 3 years ago

Thanks for the review @konstruktoid :smile: I agree your suggestion is better and have tested it locally and it fixes the issue.

Updated the PR accordingly :+1:

konstruktoid commented 3 years ago

Thanks for the update @denhamparry