docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.08k stars 170 forks source link

Credential helpers and Docker Swarm? #186

Open thnk2wn opened 4 years ago

thnk2wn commented 4 years ago

Should these credential helpers work in a Swarm? I'm using docker-credential-pass and I can see it working okay on the Swarm manager. But when I execute docker stack deploy --with-registry-auth the nodes don't seem to receive credentials correctly anymore (with or without same cred helper on worker nodes).

I'm reviewing https://github.com/moby/moby/issues/31063 but can't seem to find docs on this behavior.

thnk2wn commented 4 years ago

I figured out the issue. When running pass insert docker-credential-helpers/docker-pass-initialized-check I had to leave the passphrase empty. Otherwise it never worked with the swarm (never could find image). See also docker/docker-credential-helpers#102 (comment). I'm not sure if this is intended behavior or not but regardless, could use some documentation around all this.