osxkeychain: improve error message for non-interactive sessions

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores

MIT License

1.07k stars 169 forks source link

osxkeychain: improve error message for non-interactive sessions #193

Closed tonistiigi closed 3 years ago

tonistiigi commented 3 years ago

improves #82

The error doesn't strictly mean that keychain is locked so unlock command may not always help. Eg. binary may be blocked to access keychain item if it has been manually changed but this should cover most of the common cases without confusing the user.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

thaJeztah commented 3 years ago

ppc64 CI failing for some reason;

go vet ./secretservice
# pkg-config --cflags  -- libsecret-1
Package libsecret-1 was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsecret-1.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsecret-1' found
pkg-config: exit status 1
Makefile:63: recipe for target 'vet_linux' failed
make: *** [vet_linux] Error 2
The command "make validate" failed and exited with 2 during .

tonistiigi commented 3 years ago

@thaJeztah I doubt it is related but I don't have permissions on travis to restart or check master branch. We also don't ship this code in ppc.

thaJeztah commented 3 years ago

Merging this one, as master also has the same problem on ppc64