search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.09k stars 172 forks source link

Bump github.com/danieljoos/wincred to v1.1.2 #208

Closed crazy-max closed 3 years ago

crazy-max commented 3 years ago

Follow-up danieljoos/wincred#22

cc @thaJeztah @djs55

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

thaJeztah commented 3 years ago

Looks like @aiordache may be running into the same "timeout" issue (on Windows 11), and will give this a test.

Looks like this repository was still using travis; @crazy-max do you have time to change it to a basic github action, so that we can run CI on this PR as well?

crazy-max commented 3 years ago

Looks like @aiordache may be running into the same "timeout" issue (on Windows 11), and will give this a test.

Do you have a link to the issue? After further investigation on my side it looks like the desktop credsStore is the culprit. Not wincred or osxkeychain. See https://github.com/moby/buildkit/issues/2313#issuecomment-902353224

Looks like this repository was still using travis; @crazy-max do you have time to change it to a basic github action, so that we can run CI on this PR as well?

Sure!

thaJeztah commented 3 years ago

Do you have a link to the issue? After further investigation on my side it looks like the desktop credsStore is the culprit. Not wincred or osxkeychain. See moby/buildkit#2313 (comment)

Oh! I saw your comment, but didn't understand what you meant. Got it now!

As far as I know, desktop credsStore is the same as wincred, just a different name for the binary (not sure why that was done, but perhaps it was to prevent conflicts with users installing wincred? perhaps @ebriney knows

crazy-max commented 3 years ago

PTAL @ebriney @aiordache @djs55