search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.06k stars 169 forks source link

lint gha job and remove travis #231

Closed crazy-max closed 2 years ago

crazy-max commented 2 years ago

use golangci-lint and adds ci validation

this was the last piece in travis so we can remove travis config. I also found the pass tests were not covered because gpg key and pass was not initialized. Now pass tests run both on ci and in the Dockerfile.

codecov-commenter commented 2 years ago

Codecov Report

Merging #231 (f522992) into master (5302241) will increase coverage by 4.11%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   51.13%   55.25%   +4.11%     
==========================================
  Files           9        9              
  Lines         659      666       +7     
==========================================
+ Hits          337      368      +31     
+ Misses        286      255      -31     
- Partials       36       43       +7
Impacted Files Coverage Δ
pass/pass.go 65.48% <66.66%> (+24.92%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.