docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores

MIT License

1.06k stars 169 forks source link

simplify "go build" commands #232

Closed thaJeztah closed 2 years ago

thaJeztah commented 2 years ago

There's no need to specify the file to build, as we're building the "main" packages as a whole.

codecov-commenter commented 2 years ago

Codecov Report

Merging #232 (e847de4) into master (5302241) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   51.13%   51.13%           
=======================================
  Files           9        9           
  Lines         659      659           
=======================================
  Hits          337      337           
  Misses        286      286           
  Partials       36       36

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ZauberNerd commented 2 years ago

Cloning this repository on Linux and running make pass fails after this PR:

make pass
mkdir -p bin
go build -o bin/docker-credential-pass pass/cmd/
cannot find package "." in:
        /home/ubuntu/docker-credential-helpers/vendor/pass/cmd
make: *** [Makefile:26: pass] Error 1

Running go build -o bin/docker-credential-pass pass/cmd/main.go succeeds.

I'm on Ubuntu 22.04 with go version go1.19 linux/amd64

thaJeztah commented 2 years ago

Oh! I think I see what may be wrong; does it work if you change the makefile to use; ./pass/cmd (adding ./) ?

ZauberNerd commented 2 years ago

Oh! I think I see what may be wrong; does it work if you change the makefile to use; ./pass/cmd (adding ./) ?

Yes, thank you. That fixes the issue.