search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.06k stars 169 forks source link

Dockerfile: debian based build #239

Closed crazy-max closed 2 years ago

crazy-max commented 2 years ago

follow-up https://github.com/docker/docker-credential-helpers/pull/237#issuecomment-1230324172

using musl to build dynamically linked secretservice helper is not suitable so switch to debian based as it is for current released binaries.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

codecov-commenter commented 2 years ago

Codecov Report

Merging #239 (d15999e) into master (2f246b8) will decrease coverage by 12.17%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #239       +/-   ##
===========================================
- Coverage   55.25%   43.08%   -12.18%     
===========================================
  Files           9        7        -2     
  Lines         666      448      -218     
===========================================
- Hits          368      193      -175     
+ Misses        255      224       -31     
+ Partials       43       31       -12
Impacted Files Coverage Δ
pass/pass.go 53.98% <0.00%> (-11.51%) :arrow_down:
wincred/wincred_windows.go
osxkeychain/osxkeychain_darwin.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.