search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.06k stars 169 forks source link

Download Assets missing file extension in version 0.7.0 #242

Closed kiaka010 closed 1 year ago

kiaka010 commented 1 year ago

Hi, It seems that the download paths in the releases are missing the .tar.gz extensions in the latest build (0.7.0) compared to 0.6.4 https://github.com/docker/docker-credential-helpers/releases/tag/v0.6.4 https://github.com/docker/docker-credential-helpers/releases/tag/v0.7.0

This is causing some issues with circleci builds that use the docker orb https://circleci.com/developer/orbs/orb/circleci/docker#commands-install-docker-credential-helper DOWNLOAD_URL="https://github.com/docker/docker-credential-helpers/releases/download/${RELEASE_VERSION}/${HELPER_FILENAME}-${RELEASE_VERSION}-amd64.tar.gz"

crazy-max commented 1 year ago

Assets name has changed since 0.7.0 to support extra platforms for some helpers and therefore we need to add os/arch/variant to the release name. I guess CircleCI needs to take that into account. Suggest to contact them.

kiaka010 commented 1 year ago

@crazy-max Its been raised on their github as well. Thank you for the update

crazy-max commented 1 year ago

@kiaka010 Do you have a link to the thread? Thanks.

kiaka010 commented 1 year ago

https://github.com/CircleCI-Public/docker-orb/issues/154