docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.06k stars 169 forks source link

rewrite tests to use sub-tests, improve error-handling in tests, and use t.Cleanup() #275

Closed thaJeztah closed 1 year ago

thaJeztah commented 1 year ago

See individual commits for details

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.20 :warning:

Comparison is base (9ff5b61) 55.55% compared to head (59cb6ec) 55.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #275 +/- ## ========================================== - Coverage 55.55% 55.35% -0.20% ========================================== Files 9 9 Lines 666 672 +6 ========================================== + Hits 370 372 +2 - Misses 253 257 +4 Partials 43 43 ``` | [Impacted Files](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker) | Coverage Δ | | |---|---|---| | [osxkeychain/osxkeychain\_darwin.go](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker#diff-b3N4a2V5Y2hhaW4vb3N4a2V5Y2hhaW5fZGFyd2luLmdv) | `69.29% <57.14%> (-1.79%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

thaJeztah commented 1 year ago

This one should be ready for review now as well; @crazy-max PTAL ❤️