Open crazy-max opened 1 year ago
Patch coverage: 71.15
% and project coverage change: -2.60
:warning:
Comparison is base (
83d38ea
) 52.74% compared to head (e61a226
) 50.15%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Haven't checked yet, but possibly this also fixes https://github.com/docker/docker-credential-helpers/issues/177
So the only concerns I have is that this
secretservice
, and it looks indeed that they implemented a package for that as well in https://github.com/keybase/go-keychain/tree/c2ce0606900517e98f5dbfbd7d03f91424bc5867/secretservice<unlimited>
other back-endsIn general, I'm wondering if we should start to reorganise this repository into multiple modules, because it's now a "mono-repo" containing both the client / API / library code (client
, credentials
, registryurl
), as well as actual implementations (wincreds
, osxkeychain
, secretservice
, pass
), with (possibly) more implementations to be added (see https://github.com/docker/docker-credential-helpers/pull/268, https://github.com/docker/docker-credential-helpers/pull/235)
Some possible approaches;
implementation/
or cmd/
directory shared between implementations)
do we know what the scope is of the dependency? you mentioned
secretservice
, and it looks indeed that they implemented a package for that as well in https://github.com/keybase/go-keychain/tree/c2ce0606900517e98f5dbfbd7d03f91424bc5867/secretservice^^ that can be both a "positive" (perhaps it's an implementation we could also use), but could also be a "negative" if they start adding
<unlimited>
other back-ends
Added support for secretservice as well: https://github.com/docker/docker-credential-helpers/pull/290
closes https://github.com/docker/docker-credential-helpers/issues/280