search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.05k stars 166 forks source link

readme: install emulators when building with docker #286

Closed crazy-max closed 1 year ago

crazy-max commented 1 year ago

fixes https://github.com/docker/docker-credential-helpers/issues/260

Adds instruction to install emulators to be able to build with Docker. We don't encounter this issue on Docker Desktop as emulators are already installed. On CI we already install emulators with qemu action: https://github.com/docker/docker-credential-helpers/blob/bdd92dd0d34762226ed61e31e940a22fc03ed801/.github/workflows/build.yml#L137-L139

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.56 :warning:

Comparison is base (f8e94d9) 55.23% compared to head (2103f1b) 54.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #286 +/- ## ========================================== - Coverage 55.23% 54.68% -0.56% ========================================== Files 9 9 Lines 668 673 +5 ========================================== - Hits 369 368 -1 - Misses 256 262 +6 Partials 43 43 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/286/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.