docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.05k stars 166 forks source link

chore: use go build constraint #289

Closed crazy-max closed 1 year ago

crazy-max commented 1 year ago

fixes #176

Switch to go build constraint. This allows to run tests against the right architecture. Errors in pass tests are now properly handled.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -1.94 :warning:

Comparison is base (a652f8e) 54.68% compared to head (492a7b1) 52.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #289 +/- ## ========================================== - Coverage 54.68% 52.74% -1.94% ========================================== Files 9 9 Lines 673 673 ========================================== - Hits 368 355 -13 - Misses 262 271 +9 - Partials 43 47 +4 ``` | [Impacted Files](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker) | Coverage Δ | | |---|---|---| | [osxkeychain/osxkeychain.go](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker#diff-b3N4a2V5Y2hhaW4vb3N4a2V5Y2hhaW4uZ28=) | `69.10% <ø> (ø)` | | | [secretservice/secretservice.go](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker#diff-c2VjcmV0c2VydmljZS9zZWNyZXRzZXJ2aWNlLmdv) | `0.00% <ø> (ø)` | | | [wincred/wincred.go](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/289?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker#diff-d2luY3JlZC93aW5jcmVkLmdv) | `78.35% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/289/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

crazy-max commented 1 year ago

@thaJeztah I just noticed that this would solve #277 as well

thaJeztah commented 1 year ago

Look like it timed out or so 😔

crazy-max commented 1 year ago

@thaJeztah PTAL when you can :pray:, would like to rebase #288