search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.1k stars 173 forks source link

use designated domains in tests (RFC2606) (step 1) #294

Closed thaJeztah closed 1 year ago

thaJeztah commented 1 year ago

updates all tests, except for wincreds (handled in https://github.com/docker/docker-credential-helpers/pull/274)

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -4.33 :warning:

Comparison is base (4977273) 52.51% compared to head (a90e3fa) 48.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #294 +/- ## ========================================== - Coverage 52.51% 48.18% -4.33% ========================================== Files 9 8 -1 Lines 676 579 -97 ========================================== - Hits 355 279 -76 + Misses 274 261 -13 + Partials 47 39 -8 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/docker/docker-credential-helpers/pull/294/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=docker)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.