search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.08k stars 170 forks source link

docker-credential-oskeychain 0.8.0 get fails to retrieve records #298

Closed ericpromislow closed 1 year ago

ericpromislow commented 1 year ago

Same problem written up in #246 for v 0.7.0

Like with 0.7.0, codesign -d --verbose=4 docker-credential-osxkeychain-v0.8.0 shows Signature=adhoc instead of 

Signature size=9001
Authority=Developer ID Application: Docker Inc (9BNSXJN65R)
Authority=Developer ID Certification Authority
Authority=Apple Root CA

from version 6.x

When I try getting the record, I get this result:

$ echo https://index.docker.io/v1/ | docker-credential-osxkeychain get
The user name or passphrase you entered is not correct.

My guess is that because the app isn't correctly notarized, osxkeychain doesn't grant its request for the password

ericpromislow commented 1 year ago

Turns out we notarize the binary for release. I was testing with a dev build all this time.