search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.05k stars 166 forks source link

Dockerfile: update golangci-lint to v1.55.2 #309

Closed thaJeztah closed 6 months ago

codecov-commenter commented 6 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (8fc3306) 52.51% compared to head (f110cd3) 52.23%. Report is 2 commits behind head on master.

Files Patch % Lines
credentials/error.go 0.00% 3 Missing :warning:
client/client.go 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #309 +/- ## ========================================== - Coverage 52.51% 52.23% -0.29% ========================================== Files 9 9 Lines 676 672 -4 ========================================== - Hits 355 351 -4 Misses 274 274 Partials 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thaJeztah commented 6 months ago

right; looks like XX update isn't working;

 > [linux/amd64->darwin/arm64 build-darwin 1/1] RUN --mount=type=bind,target=.     --mount=type=cache,target=/root/.cache     --mount=type=cache,target=/go/pkg/mod     --mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk     --mount=type=bind,source=/tmp/.version,target=/tmp/.version,from=version     --mount=type=bind,source=/tmp/.revision,target=/tmp/.revision,from=version <<EOT (set -ex...):
87.01 + cat /tmp/.revision
87.01 + make build-osxkeychain build-pass PACKAGE=github.com/docker/docker-credential-helpers VERSION=v0.8.0-7-g14358f5 REVISION=14358f5773df4473080864c96cf6aca39d49e8d6 DESTDIR=/out
87.01 go build -trimpath -ldflags="-s -w -X github.com/docker/docker-credential-helpers/credentials.Version=v0.8.0-7-g14358f5 -X github.com/docker/docker-credential-helpers/credentials.Revision=14358f5773df4473080864c96cf6aca39d49e8d6 -X github.com/docker/docker-credential-helpers/credentials.Package=github.com/docker/docker-credential-helpers -X github.com/docker/docker-credential-helpers/credentials.Name=docker-credential-osxkeychain" -o "/out/docker-credential-osxkeychain" ./osxkeychain/cmd/
115.5 # github.com/docker/docker-credential-helpers/osxkeychain/cmd
115.5 /usr/local/go/pkg/tool/linux_amd64/link: running arm64-apple-macos10.11-clang failed: exit status 255
115.5 /usr/bin/arm64-apple-macos10.11-ld: 9: sigtool-gensig: not found
115.5 clang: error: unable to execute command: No such file or directory
115.5 clang: error: linker command failed due to signal (use -v to see invocation)
115.5 
115.5 make: *** [Makefile:27: build-osxkeychain] Error 1