search

docker / docker-credential-helpers

Programs to keep Docker login credentials safe by storing in platform keystores
MIT License
1.05k stars 166 forks source link

pass: Get: remove redundant stat #323

Closed thaJeztah closed 2 months ago

thaJeztah commented 2 months ago

listPassdir already handles "not found" errors, in which case it returns an empty result. Previously this would return a custom error, but since 1bb9aa321022b0fcf5b484fe2fc12d9cef1f4b6e (https://github.com/docker/docker-credential-helpers/pull/321), an empty result produces a errCredentialsNotFound, making this check redundant.

This patch removes the redundant check.

- A picture of a cute animal (not mandatory but encouraged)

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.28%. Comparing base (74840b3) to head (a14669f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #323 +/- ## ========================================== + Coverage 54.93% 55.28% +0.35% ========================================== Files 9 9 Lines 628 624 -4 ========================================== Hits 345 345 + Misses 237 234 -3 + Partials 46 45 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.