codecov-commenter
commented
2 months ago Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.
Project coverage is 55.11%. Comparing base (
6b9df3e) to head (c805249).
| Files | Patch % | Lines |
|---|---|---|
| secretservice/secretservice.go | 0.00% | 3 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #324 +/- ## ========================================== - Coverage 55.28% 55.11% -0.18% ========================================== Files 9 9 Lines 624 626 +2 ========================================== Hits 345 345 - Misses 234 236 +2 Partials 45 45 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Secretservice entries have a "label". This is intended to be a human-readable description. It's actually called "Description" in UIs like seahorse, and the listing of existing secrets shows this as a name for each one.
The entries stored by the credential helper set this to simply the repository URL. This is rather unfriendly, since entries like "gitlab.com" and "index.docker.io/v1" show up. Mixed in with entries from all other applications, it's hard to figure out what application owns each entry.
This commit changes the label used when saving entries to be something human-readable (this is the intent of the "label" field, btw). Because of the naming scheme, this also results in all entries being shown together by default (since UIs tend to sort lexicographically).
New entries will now be stores as:
Docker credentials for $REGISTRY_URL
Note that items stored by the secret service have multiple fields inside of them. One of those fields is called "label", and is used by the helper to filter items from the secret service. This "label" field is entirely unrelated to the items' label. The naming is most unfortunate.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)