docker / docker-py

A Python library for the Docker Engine API
https://docker-py.readthedocs.io/
Apache License 2.0
6.83k stars 1.67k forks source link

docker-py issue with dockerswarm and jupyterhub #1078

Closed farassadek closed 8 years ago

farassadek commented 8 years ago

Hi All,

I am working on jupyterhub project for School of Engineering at Harvard University. The project implemented in Amazon AWS environment. Using a single EC2 instance, the project worked wonderfully.

I then decide to use the docker swarm to implement JupyterHub on several instances. It did not wok until I modified (adding one line of code ) docker/utils/utils.py.

in "/usr/lib/python3.4/site-packages/docker/utils/utils.py" in function "_convert_port_binding " (line 260) , at the end of the function I added

result['HostIp'] = ""
return result

This hack will enable the swarm to start docker on any instance with an IP of 0.0.0.0 (instead of 127.0.0.), so that jupyterhub proxy will allow the user to access this docker instance from within Jupyterhub instance(If you like I can explain more so you will have a better understanding of the issue).

If you have a better solution than my hack I would love to use it (I'd rather not change a code on the fly), or if it is possible to implement this functionality so my project works without modifying any of packages.

farassadek commented 8 years ago

Nevermind guys I found the issue. It is a config option in dockerswarm