Open kasium opened 3 months ago
I can still see the resource warning from https://github.com/docker/docker-py/issues/1293 in some cases:
pytest.PytestUnraisableExceptionWarning: Exception ignored in: <socket.socket fd=-1, family=1, type=1, proto=0> Traceback (most recent call last): File "<frozen _collections_abc>", line 435, in __subclasshook__ ResourceWarning: unclosed <socket.socket fd=41, family=1, type=1, proto=0, raddr=/var/run/docker.sock>
I use python 3.12 and docker-py 7.1.
I guess that the close method of BaseHTTPAdapter in docker/transport/basehttpadapter.py should call close on the pool rather than clear
close
BaseHTTPAdapter
docker/transport/basehttpadapter.py
clear
I'm not able to reproduce the warning. Also, Calling clear closes all urllib3.poolmanager.PoolManager instance so no issue here
urllib3.poolmanager.PoolManager
Maybe it's worth to mention that I use 1.26.18
I can still see the resource warning from https://github.com/docker/docker-py/issues/1293 in some cases:
I use python 3.12 and docker-py 7.1.
I guess that the
close
method ofBaseHTTPAdapter
indocker/transport/basehttpadapter.py
should callclose
on the pool rather thanclear