docker / docs

Source repo for Docker's Documentation
https://docs.docker.com
Apache License 2.0
4.12k stars 7.12k forks source link

Error in DOCKER_USERNAME vs. DOCKERHUB_USERNAME #20447

Open sjdthree opened 1 month ago

sjdthree commented 1 month ago

Is this a docs issue?

Type of issue

Information is incorrect

Description

this line:

  1. Create a new Repository variable named DOCKER_USERNAME and your Docker ID as value.

doesnt match the code later in the file here:

          username: ${{ vars.DOCKERHUB_USERNAME }}

and causes an error on login.

(also after i fixed that i'm now getting: "Error: buildx failed with: ERROR: invalid tag "/clockbox:latest": invalid reference format" -- not sure how to fix.

Location

https://docs.docker.com/build/ci/github-actions/

Suggestion

pick one: DOCKERHUB or DOCKER and make consistent.

sjdthree commented 1 month ago

Update: The above "Error: buildx.." I mentioned was the same issue. I missed the second DOCKER_USERNAME within the file:

          tags: ${{ vars.DOCKERHUB_USERNAME }}/clockbox:latest
thaJeztah commented 3 weeks ago

cc @crazy-max