docker / docs

Source repo for Docker's Documentation
https://docs.docker.com
Apache License 2.0
4.13k stars 7.14k forks source link

Cannot get to the getGreeting.JS file on 'Develop with Containers' Guide #20636

Open JHBlack opened 3 weeks ago

JHBlack commented 3 weeks ago

Is this a docs issue?

Type of issue

Information is incorrect

Description

The backend/src/routes/getGreeting.js cannot be found in the backend container of this project. Could there be a more detailed description on how to find that file? The src directory could not be found using the file patch instructions.

image

Location

https://docs.docker.com/guides/getting-started/develop-with-containers/

Suggestion

Is there a different filepath to get to the getGreeting.js file?

JHBlack commented 3 weeks ago

I found that the file path on my machine to be on the backend container usr/local/app/src/routes/getGreeting.js. May I create a pull request for this change?

dvdksn commented 3 weeks ago

Hello, thank you for creating this issue.

I can see why this might be confusing. The reference in the instruction (backend/src/routes/getGreeting.js) assumes that the reader knows that it's the path relative to the root of the project directory on the host filesystem.

We need to clarify that:

If you feel like it, you are more than welcome to raise a PR with these changes @JHBlack. If you do, I'll help you review it.

JHBlack commented 3 weeks ago

Thanks will do. Should I @ you when i create the PR?

dvdksn commented 3 weeks ago

Please do!

JHBlack commented 3 weeks ago

Hey dvdksn,

I can't seem to get the docker compose watch file to work on my branch to do local development. Do you know what I can do to fix it? I get the "configuration file provided: not found"

JHBlack commented 3 weeks ago

Hey got further along, but I'm still stuck on trying to run the local development Docker container. Any chance we could discuss more on Discord?