search

docker / engine-api

DEPRECATED: Please see https://github.com/docker/docker/tree/master/client
Apache License 2.0
265 stars 163 forks source link

Migrate docker/cliconfig to engine-api ? #106

Open pdalpra opened 8 years ago

pdalpra commented 8 years ago

Hi Docker developers :)

I just heard about this project, and having a officially supported Go binding to interact with Docker API is great.

However, like other Go bindings such as go-dockerclient that provide it, it would be very nice to be able to get a map[string]types.AuthConfig from ~/.docker/config.json/.dockercfg. In docker/docker, this feature is provided by the cliconfig.

Would it be possible to migrate at least the reading part of cliconfig to engine-api ?

I'd be glad to provide a PR if you like.

calavera commented 8 years ago

I really have mixed feelings about this. That structure is easy enough to build a parser yourself, but I understand that it could be convenient to have a canonical implementation.

FWIW, registry authentication will have some changes in 1.11 that we'd need to consider if we move this forward:

  1. External stores just landed in https://github.com/docker/docker/pull/20107
  2. Long lived tokens rather than user/password will probably land :soon: https://github.com/docker/engine-api/pull/108