docker / engine-api

DEPRECATED: Please see https://github.com/docker/docker/tree/master/client
Apache License 2.0
264 stars 163 forks source link

request: don't decorate context errors #355

Closed tamird closed 8 years ago

tamird commented 8 years ago

Comparing directly to sentinels is handy when implementing retries.

dnephin commented 8 years ago

LGTM

tamird commented 8 years ago

@dnephin what's the workflow here? What needs to happen between "LGTM" and merge?

dnephin commented 8 years ago

There needs to be two maintainers "LGTM", then it gets merged. So we're waiting on another.

tamird commented 8 years ago

@thaJeztah @calavera can you guys take a look? You appear to be the main contributors to this file.

vdemeester commented 8 years ago

LGTM 🐸