docker / extensions-submissions

Submit your Docker Extension here
Apache License 2.0
11 stars 2 forks source link

[Submission]: Selenium Docker Extension #109

Closed ajeetraina closed 1 year ago

ajeetraina commented 1 year ago

Docker Hub repository name

ajeetraina/selenium-docker-extension

Terms of services

github-actions[bot] commented 1 year ago

:white_check_mark: @ajeetraina has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 1 year ago

:x: Validation failed with the following errors

(required) image label "com.docker.extension.changelog" is set to empty string in the Dockerfile: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ The extension "ajeetraina/selenium-docker-extension:1.0.0" hasn't passed the checks to be published.

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i ajeetraina/selenium-docker-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

ajeetraina commented 1 year ago

/validate

github-actions[bot] commented 1 year ago

:x: Validation failed with the following errors

(required) image label "com.docker.extension.changelog" is set to empty string in the Dockerfile: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ The extension "ajeetraina/selenium-docker-extension:1.0.0" hasn't passed the checks to be published.

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i ajeetraina/selenium-docker-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

ajeetraina commented 1 year ago

/validate

github-actions[bot] commented 1 year ago

:white_check_mark: The extension ajeetraina/selenium-docker-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

lucbpz commented 1 year ago

Hi @ajeetraina! I installed the extension and the main screen appears blank. I see there's a Selenium container that can be opened on localhost:4442 but it doesn't show anything either.

Do you want to address this before publishing?

gtardif commented 1 year ago

Same for me initially. After I moved to containers screen and came back to the extension, then I can se the UI. It's likely lacking a waiting screen for when the backend containers are still starting ? (This is highly impacting the user experience, as users navigate to the extension just after installing, and the first experience is "it is broken")

ajeetraina commented 1 year ago

@lucbpz I noticed that whenever we use Embedded UI, it takes 7-8 seconds for UI to come up. Is there any way we can add a waiting screen? or I wonder if there is a better way?

lucbpz commented 1 year ago

@ajeetraina The issue on my side was resolved by increasing the allocated memory to 4GB, in case you want to add this to the description.

About the Embedded UI, it only happens on the first start, when the container is still starting and not available yet. The behavior is the same as if you visit localhost:4444 in the browser. For now the waiting screen needs to be added manually - you could ping / request the service every X seconds and check when the container is up and running.

ajeetraina commented 1 year ago

@lucbpz I have updated the description. Will be performing the validation again.

ajeetraina commented 1 year ago

/validate

github-actions[bot] commented 1 year ago

:white_check_mark: The extension ajeetraina/selenium-docker-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

github-actions[bot] commented 1 year ago

:white_check_mark: The extension ajeetraina/selenium-docker-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

publisher-extensions-bot[bot] commented 1 year ago

:tada: Congratulations, your extension has been published to the marketplace.

It may not appear in your Docker Desktop yet. In that case, restart Docker Desktop (don't worry, users will see it as soon as the cache is refreshed, every ~12 hours).

If you haven't already, please tell us about your experience building a Docker Desktop extension here.