docker / extensions-submissions

Submit your Docker Extension here
Apache License 2.0
11 stars 2 forks source link

[Submission]: MindsDB Docker Extension #140

Closed collabnix closed 9 months ago

collabnix commented 9 months ago

Docker Hub repository name

ajeetraina/mindsdb-docker-extension

Terms of services

github-actions[bot] commented 9 months ago

:white_check_mark: @collabnix has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 9 months ago

:x: Validation failed with the following errors

Pulled imageChecked image labelsChecked metadata.json'/metadata.json' file not found at the root of the image filesystem. In the Dockerfile, check if the metadata.json is copied in some subfolder by error.Checked image tag is semverChecked image is multiplatformthe image for platform "linux/amd64" is not pushed to DockerHub: https://docs.docker.com/desktop/extensions-sdk/extensions/multi-arch/Checked extension is compatible with current SDK versionInstalled extension successfullyRemoved extension successfullyThe extension "ajeetraina/mindsdb-docker-extension:1.0.0" hasn't passed the checks to be published.

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i ajeetraina/mindsdb-docker-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

collabnix commented 9 months ago

Strange. The command worked perfectly for me locally.

docker extension validate ajeetraina/mindsdb-docker-extension:1.0.0
INFO Checked image labels
INFO Checked metadata.json
INFO Checked image tag is semver
INFO Checked image is multiplatform
INFO 🎉 The extension "ajeetraina/mindsdb-docker-extension:1.0.0" passes the validation checks.
INFO If you want to make your extension available in the marketplace, please submit it for publication at https://www.docker.com/products/extensions/submissions/
collabnix commented 9 months ago

/validate

github-actions[bot] commented 9 months ago

:x: Validation failed with the following errors

Pulled imageChecked image labelsChecked metadata.json'/metadata.json' file not found at the root of the image filesystem. In the Dockerfile, check if the metadata.json is copied in some subfolder by error.Checked image tag is semverChecked image is multiplatformthe image for platform "linux/amd64" is not pushed to DockerHub: https://docs.docker.com/desktop/extensions-sdk/extensions/multi-arch/Checked extension is compatible with current SDK versionInstalled extension successfullyRemoved extension successfullyThe extension "ajeetraina/mindsdb-docker-extension:1.0.0" hasn't passed the checks to be published.

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i ajeetraina/mindsdb-docker-extension

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

Frezzle commented 9 months ago

That is strange; for me locally it shows the same as GitHub Actions:

$ docker extension validate ajeetraina/mindsdb-docker-extension:1.0.0
INFO Pulled image                                 
INFO Checked image labels                         
INFO Checked metadata.json                        
INFO Checked image tag is semver                  
INFO Checked image is multiplatform               
ERRO the image for platform "linux/amd64" is not pushed to DockerHub: https://docs.docker.com/desktop/extensions-sdk/extensions/multi-arch/ 
ERRO The extension "ajeetraina/mindsdb-docker-extension:1.0.0" hasn't passed the checks to be published.

It's only arm64 on Docker Hub at the moment: Screenshot 2023-12-12 at 09 31 08

So for the time being, if you follow this doc then it shows how to push both linux architectures to Docker Hub. Then try /validate again 🤞

ajeetraina commented 9 months ago

Just checked https://hub.docker.com/layers/mindsdb/mindsdb/latest/images/sha256-dcab90ac1ad7df77a47cb81d88707f3d118c1cdcda362b4deeb7a1d866153501?context=explore and it has both the arch images.

docker run --rm mplatform/mquery mindsdb/mindsdb:latest
Image: mindsdb/mindsdb:latest (digest: sha256:a96ee5adb2dfca570350b1537e3cc43cd5ac11c25eddc4778c9bfeeff585d3f0)
 * Manifest List: Yes (Image type: application/vnd.oci.image.index.v1+json)
 * Supported platforms:
   - linux/amd64
   - linux/arm64
   - unknown/unknown
   - unknown/unknown

Will try to use the latest mindsdb image

ajeetraina commented 9 months ago

@Frezzle I just built a new Mindsdb Extension that includes both Amd64 and Arm64 platform support.

docker run --rm mplatform/mquery ajeetraina/mindsdb-docker-extension:1.0.2
Image: ajeetraina/mindsdb-docker-extension:1.0.2 (digest: sha256:239e8b780a6295f9662b0f40875bc0b7f0d10f4bdf4b76c29449d3b3d5f41406)
 * Manifest List: Yes (Image type: application/vnd.oci.image.index.v1+json)
 * Supported platforms:
   - linux/amd64
   - linux/arm64
   - unknown/unknown
   - unknown/unknown

Can you please check?

ajeetraina commented 9 months ago

/validate

github-actions[bot] commented 9 months ago

:white_check_mark: The extension ajeetraina/mindsdb-docker-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

github-actions[bot] commented 9 months ago

:white_check_mark: The extension ajeetraina/mindsdb-docker-extension is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

publisher-extensions-bot[bot] commented 9 months ago

:tada: Congratulations, your extension has been published to the marketplace.

It may not appear in your Docker Desktop yet. In that case, restart Docker Desktop (don't worry, users will see it as soon as the cache is refreshed, every ~12 hours).

If you haven't already, please tell us about your experience building a Docker Desktop extension here.

Frezzle commented 9 months ago

It's now published @ajeetraina, nice work! 🎉 Screenshot 2023-12-13 at 10 19 42

I did notice a few things that may be worth looking into:

ajeetraina commented 9 months ago

@Frezzle I have updated description under the Dockerfile with the following content and pushed it to Docker Hub

 FROM alpine
LABEL org.opencontainers.image.title="Mindsdb" \
    org.opencontainers.image.description="Streamline AI development with MindsDB in your Docker environment. Deploy, manage, and scale your AI models seamlessly" \
    org.opencontainers.image.vendor="Ajeet Singh Raina" \
...

Regarding the initial loading, I too experienced the same slow speed. Is it because I am using embedded UI. Wonder if there is a way we can add a note that says "Wait. It's loading.." so as to avoid the confusion.

Frezzle commented 9 months ago

I have updated description under the Dockerfile with the following content and pushed it to Docker Hub

Nice one! Though I think you accidentally undid the two linux architectures; now it's just one again: Screenshot 2023-12-13 at 11 05 23

ajeetraina commented 9 months ago

I will get it fixed. Rebuilding it now.