docker / extensions-submissions

Submit your Docker Extension here
Apache License 2.0
11 stars 2 forks source link

[Submission]: ImageX By Checkmarx Docker extension #142

Closed greensd4 closed 10 months ago

greensd4 commented 10 months ago

Docker Hub repository name

checkmarx/imagex

Terms of services

github-actions[bot] commented 10 months ago

:white_check_mark: @greensd4 has accepted the terms of service.

The automatic validation of your extension has started, you will see the result in ~10 minutes :hourglass_flowing_sand:.

github-actions[bot] commented 10 months ago

:x: Validation failed with the following errors

Pulled imageChecked image labels(required) image label "com.docker.extension.categories" is missing in the Dockerfile: https://docs.docker.com/desktop/extensions-sdk/extensions/labels/ Checked metadata.jsonChecked image tag is semverChecked image is multiplatformChecked extension is compatible with current SDK versionInstalled extension successfullyRemoved extension successfullyThe extension "checkmarx/imagex:0.0.23362-ce3901c" hasn't passed the checks to be published.

Please fix the issues and check everything is ok locally with the following command:

docker extension validate -a -s -i checkmarx/imagex

Then you can trigger the validation commenting /validate when you are ready.

See https://docs.docker.com/desktop/extensions-sdk/extensions/validate/ for more information.

greensd4 commented 10 months ago

/validate

github-actions[bot] commented 10 months ago

:white_check_mark: The extension checkmarx/imagex is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

greensd4 commented 10 months ago

Any updates here?

greensd4 commented 10 months ago

/validate

github-actions[bot] commented 10 months ago

:white_check_mark: The extension checkmarx/imagex is valid :tada:.

Now, @docker/extensions will authorise the publication of the extension to the marketplace. Once the extension is published, this issue will be closed.

In the meantime, please tell us about your experience building a Docker Desktop extension here: https://survey.alchemer.com/s3/7184948/Publishers-Feedback-Form.

publisher-extensions-bot[bot] commented 10 months ago

:tada: Congratulations, your extension has been published to the marketplace.

It may not appear in your Docker Desktop yet. In that case, restart Docker Desktop (don't worry, users will see it as soon as the cache is refreshed, every ~12 hours).

If you haven't already, please tell us about your experience building a Docker Desktop extension here.

benja-M-1 commented 9 months ago

Hi @greensd4 I noticed the extension does not have a logo on the marketplace. To fix that you must reference the URL to the logo in the label of the image rather than referencing the file.

com.docker.desktop.extension.icon=checkmarx-icon.svg

Should be

com.docker.desktop.extension.icon=https://cx-public-media-files.s3.amazonaws.com/checkmarx-icon.svg

The marketplace uses this value to retrieve the assets to display in the UI.